Skip to content

refactor: modernize type hints to Python 3.10+ union syntax #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Copilot wants to merge 2 commits into from
Closed

refactor: modernize type hints to Python 3.10+ union syntax #42

Copilot wants to merge 2 commits into from

Conversation

Copy link
Contributor

Copilot AI commented Oct 30, 2025 •
edited
Loading

Addresses feedback from #40 to use modern union syntax for type annotations instead of typing.Optional.

Changes

  • Replace Optional[InvoiceRequest] with InvoiceRequest | None in app/routers/operator.py:298
  • Remove unused typing.Optional import

Example

# Before
from typing import Optional

async def invoice(
    invoice_id: str = Path(...),
    data: Optional[InvoiceRequest] = None,
    _current_user: User | None = current_user_flexible_dep,
) -> InvoiceResponse:
    ...

# After
async def invoice(
    invoice_id: str = Path(...),
    data: InvoiceRequest | None = None,
    _current_user: User | None = current_user_flexible_dep,
) -> InvoiceResponse:
    ...

Aligns with project's Python 3.11+ requirement where PEP 604 union syntax is standard.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI mentioned this pull request Oct 30, 2025
Closed
4 tasks
Copilot AI changed the title [WIP] Update to address feedback on hotfix CI precommit refactor: modernize type hints to Python 3.10+ union syntax Oct 30, 2025
Copilot AI requested a review from Neiland85 October 30, 2025 14:59
@Neiland85
Copy link
Owner

Neiland85 commented Dec 10, 2025

Closing this PR. After the 2025 refactor, these changes are fully superseded and incompatible with the new system design.

Keeping it open offers no benefit and only adds unnecessary clutter to the repository.

@Neiland85 Neiland85 closed this Dec 10, 2025
@Neiland85 Neiland85 deleted the copilot/sub-pr-40-again branch December 10, 2025 16:51
Neiland85 added a commit that referenced this pull request Dec 13, 2025
@Neiland85
fix(codeql): remove unused imports in router_clean.py
e656500 
- Remove unused typing imports: Any, Dict, List
- Remove unused HTTPException from fastapi
- Remove unused JSONResponse from fastapi.responses

Fixes CodeQL alerts #21, #42, #43
Neiland85 added a commit that referenced this pull request Dec 13, 2025
@Neiland85
fix(codeql): remove unused imports in router_clean.py
f70ec70 
Removes:
- typing.Any, typing.Dict, typing.List (unused)
- fastapi.HTTPException (unused)
- fastapi.responses.JSONResponse (unused)

Closes CodeQL alerts #21, #42, #43
@Neiland85 Neiland85 mentioned this pull request Dec 13, 2025
Merged
22 tasks
Neiland85 added a commit that referenced this pull request Dec 13, 2025
@Neiland85
fix(codeql): remove unused imports in router_clean.py (#116)
b352c86 
Removes:
- typing.Any, typing.Dict, typing.List (unused)
- fastapi.HTTPException (unused)
- fastapi.responses.JSONResponse (unused)

Closes CodeQL alerts #21, #42, #43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Neiland85 Neiland85 Awaiting requested review from Neiland85

Assignees

@Neiland85 Neiland85

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Neiland85